Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #84 general ui fixes for marketplace #150

Merged
merged 2 commits into from
Jan 31, 2020
Merged

fix: #84 general ui fixes for marketplace #150

merged 2 commits into from
Jan 31, 2020

Conversation

vuhuucuong
Copy link
Contributor

fixed #84

@github-actions github-actions bot added the marketplace Relates to the Marketplace label Jan 31, 2020
@vuhuucuong vuhuucuong requested a review from duong-se January 31, 2020 10:02
willmcvay
willmcvay requested changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but if it's possible, would be great for the Grid to be more flexible. If it's too complicated, am happy to approve but if it's trivial, would be a good enhancement :-)

packages/marketplace/src/styles/blocks/app-detail.scss Outdated Show resolved Hide resolved
@vuhuucuong vuhuucuong force-pushed the fix/84-general-ui-fixes-for-marketplace branch from 6b1c4b4 to fea6f3e Compare January 31, 2020 11:43
@vuhuucuong
Copy link
Contributor Author

Changed to <Grid> instead of <GridFiveCol> with custom logic. Pls help me to review it again :) @willmcvay

duong-se
duong-se approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

willmcvay
willmcvay approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vuhuucuong vuhuucuong force-pushed the fix/84-general-ui-fixes-for-marketplace branch from fea6f3e to 18d21de Compare January 31, 2020 15:27
@vuhuucuong vuhuucuong merged commit fff03a7 into master Jan 31, 2020
@vuhuucuong vuhuucuong deleted the fix/84-general-ui-fixes-for-marketplace branch January 31, 2020 15:41
@vuhuucuong vuhuucuong mentioned this pull request Feb 4, 2020
Merged
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@duong-se
Merge pull request #150 from reapit/fix/cld-552-upgrade-roll-up
4f66e2a 
[CLD-552] upgrade roll up
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@vuhuucuong
fix: #84 general ui fixes for marketplace (#150)
fc0b668 
* fix: #84 general ui fixes for marketplace

* fix: remove css important, change render logic
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannd4 dannd4 Awaiting requested review from dannd4

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@zlatanpham zlatanpham Awaiting requested review from zlatanpham

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@duong-se duong-se Awaiting requested review from duong-se

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@vuhuucuong vuhuucuong

Labels
marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

General UI fixes for the Marketplace
4 participants
@vuhuucuong @willmcvay @duong-se @phmngocnghia